[PATCH] D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 30 04:39:17 PDT 2019


ro marked 2 inline comments as done.
ro added inline comments.


================
Comment at: llvm/trunk/CMakeLists.txt:837
+# Build with _FILE_OFFSET_BITS=64 on Solaris to match g++ >= 9.
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
+          add_definitions("-D_FILE_OFFSET_BITS=64")
----------------
MaskRay wrote:
> Doesn't `${CMAKE_SYSTEM_NAME} MATCHES "SunOS"` imply `UNIX`?
I guess so: just copied it from the AIX clause above.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64483/new/

https://reviews.llvm.org/D64483





More information about the llvm-commits mailing list