[PATCH] D65408: [Attributor] Heap-To-Stack Conversion

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 marked an inline comment as done.
sstefan1 added a comment.

In D65408#1605351 <https://reviews.llvm.org/D65408#1605351>, @jdoerfert wrote:

> Top-level functions declarations should have attributes to make them as restricted as needed, e.g. `sync_func` should probably be `nofree` or renamed to `sync_free_func`.


Yes. I'll refine them along the way.

In D65408#1605240 <https://reviews.llvm.org/D65408#1605240>, @xbolva00 wrote:

> Negative tests:
>  Malloc in loop body
>  Irreducible cfg
>
> ?


Thanks for suggestions. These will also be added. I will probably put some code today, so I can actually test this on something.



================
Comment at: llvm/test/Transforms/FunctionAttrs/heap_to_stack.ll:48
+  ret void
+}
+
----------------
jdoerfert wrote:
> What is the difference between Test 2 and 3?
Nothing :). I meant to put call to nosync function here. I'll correct this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65408/new/

https://reviews.llvm.org/D65408