[PATCH] D65424: [Packetizer] Increase the size of DFAInput bitfield to allow up to 32 units

[James Molloy via Phabricator via llvm-commits]

jmolloy added inline comments.


================
Comment at: llvm/lib/CodeGen/DFAPacketizer.cpp:56
 
-static DFAInput addDFAFuncUnits(DFAInput Inp, unsigned FuncUnits) {
-  return (Inp << DFA_MAX_RESOURCES) | FuncUnits;
+DFAInput addDFAFuncUnits(DFAInput Inp, unsigned FuncUnits) {
+  return DFAInput((Inp.first << DFA_MAX_RESOURCES) |
----------------
static


================
Comment at: llvm/utils/TableGen/DFAPacketizerEmitter.cpp:68
 
-  DFAInput addDFAFuncUnits(DFAInput Inp, unsigned FuncUnits) {
-    return (Inp << DFA_MAX_RESOURCES) | FuncUnits;
-  }
+DFAInput addDFAFuncUnits(DFAInput Inp, unsigned FuncUnits) {
+  static_assert(DFA_MAX_RESOURCES < sizeof(Inp.first)*8,
----------------
Formatting is off here.


================
Comment at: llvm/utils/TableGen/DFAPacketizerEmitter.cpp:298
+                                             /*Hex*/ true, false, false)
+                    << llvm::FormattedNumber(InsnInput.first, 0, /*width*/ 8,
+                                             /*Hex*/ true, false, false)
----------------
Don't you need InsnInput.second here?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65424/new/

https://reviews.llvm.org/D65424