[PATCH] D65326: Fix for a dangling point bug in DeadStoreElimination pass

Tue Jul 30 02:05:09 PDT 2019

quic_aankit added a comment.

In D65326#1603693 <https://reviews.llvm.org/D65326#1603693>, @fhahn wrote:

> I think `SetVector` would be more suitable and lead to slightly simpler code (http://llvm.org/doxygen/classllvm_1_1SetVector.html)
>
> Also, could you upload the patch with more context? (`git show HEAD -U999999`)

Uploaded the patch with more context.

The main motivation to use MapVector is for searching the deletedInstruction in the list of lastThrowing Instructions (Line120). With SetVector this step will be expensive.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65326/new/

https://reviews.llvm.org/D65326