[PATCH] D65056: [ASan][test] XFAIL AddressSanitizer-*-sunos :: TestCases/intercept-rethrow-exception.cc on Solaris

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 30 00:57:55 PDT 2019


ro added a comment.

In D65056#1604957 <https://reviews.llvm.org/D65056#1604957>, @vitalybuka wrote:

> In D65056#1603902 <https://reviews.llvm.org/D65056#1603902>, @ro wrote:
>
> > Ping?  It's been a week now.  Is there some policy not to xfail the test which as documented in the bug cannot pass on Solaris?
>
>
> If the test fails consistently on the platform and there is a chance to make it pass some day, I would prefer to have XFAIL.


I certainly mean to construct a massivly reduced testcase and check with the Solaris linker engineer if he sees a way to avoid
triggering the recursive call to `AsanInitInternal` triggered by `dlsym`.  However, right now there are more pressing issues like
2-stage builds failing on both Solaris/SPARC and x86.

> You can try to check activity of reviewers or just extend a list.
>  @samsonov is currently not active member of LLVM

I'd started with the listed maintainers initially.

> @kcc was just too busy

I see.  I've tried to extend the reviewer list beyond the maintainers, but found it somewhat difficult to determine appropriate
candidates in areas that see not too much activity.  Probably need to broaden where I look...


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65056/new/

https://reviews.llvm.org/D65056





More information about the llvm-commits mailing list