[PATCH] D65430: Add `--write-dependencies` option, which is equivalent to compiler option -MD.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 29 21:19:34 PDT 2019
pcc added inline comments.
================
Comment at: lld/ELF/Driver.cpp:1408
+ sys::path::remove_dots(path, /*remove_dot_dot=*/true);
+ os << " \\\n " << path;
+ }
----------------
Clang has a bunch of complicated logic to handle escaping here: http://llvm-cs.pcc.me.uk/tools/clang/lib/Frontend/DependencyFile.cpp#299
Would it be worth extracting it into a function and using it from here? Or maybe there's something simpler that we can do that would be understood by ninja et al.?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65430/new/
https://reviews.llvm.org/D65430
More information about the llvm-commits
mailing list