[PATCH] D47210: [lit] Fix the `--max-time` flag feature which was completely broken.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 29 15:51:30 PDT 2019


delcypher added a comment.

In D47210#1385463 <https://reviews.llvm.org/D47210#1385463>, @bryanpkc wrote:

> Is there any plan to fix this patch and land it? We use `--max-time` in our tests and intermittently run into the Python assertion. We can work around the problem by killing lit.py with another timer, but then we lose the report that lit.py produces at the end of the run.


@bryanpkc

No. I don't have time to work on it. There is a fundamental problem with this patch in that long running tasks do not killed properly (see https://reviews.llvm.org/D47210#1115648 ).
Until that problem is solved we cannot land this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47210/new/

https://reviews.llvm.org/D47210





More information about the llvm-commits mailing list