[PATCH] D64209: [DWARF] Make DWARFDataExtractor possible to be used with both 32- and 64-bit offsets.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 29 13:34:56 PDT 2019


probinson added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDataExtractor.h:39
+  template <typename TOff>
+  uint64_t getRelocatedValue(uint32_t Size, TOff *Off,
                              uint64_t *SectionIndex = nullptr) const;
----------------
aprantl wrote:
> I'm surprised that Size is still 32 bits?
This is the size of the relocated value, and can be no larger than 8; is there some reason to make the type wider?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64209/new/

https://reviews.llvm.org/D64209





More information about the llvm-commits mailing list