[PATCH] D65280: Add a pass to lower is.constant intrinsics Needs ReviewPublic

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

Couple of random comments, haven't looked at most of it yet.



================
Comment at: include/llvm/Analysis/InstructionSimplify.h:258
+                           OptimizationRemarkEmitter *ORE = nullptr,
+                           bool SimplifyCFG = false);
 
----------------
Really would like to avoid boolean arguments like this.


================
Comment at: lib/Analysis/InstructionSimplify.cpp:5047
 
+static Value *simplifyBranch(BranchInst *BI, bool SimplifyCFG) {
+  if (!SimplifyCFG || BI->isUnconditional())
----------------
This seems to return nullptr everywhere?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65280/new/

https://reviews.llvm.org/D65280