[PATCH] D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp updated this revision to Diff 212209.
wolfgangp marked 24 inline comments as done.
wolfgangp added a comment.

- Undertook some refactoring of the change with the following motivation: The printStackSize* methods do mostly extracting and validating, printing the output is only a minor part. Yet they were methods of the GNUStyle class, which would have made it more difficult to implement LLVM style dumping. So I moved them mostly into the base class (DumpStyle), and delegated the printing mostly to a new method printStackSizeEntry(), which is style specific.
- Addressed the formatting comments
- Added 2 test cases (demangling and verifiying the 'not implemented' message we get from llvm-readobj.
- Explained the rationale using consumeError().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65313/new/

https://reviews.llvm.org/D65313

Files:
  llvm/docs/CommandGuide/llvm-readelf.rst
  llvm/test/tools/llvm-readobj/stack-sizes.test
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/tools/llvm-readobj/ObjDumper.h
  llvm/tools/llvm-readobj/llvm-readobj.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65313.212209.patch
Type: text/x-patch
Size: 33213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190729/bdb81eb7/attachment.bin>