[PATCH] D65411: [FileCollector] Add a VFS that records FS accesses using the FileCollector
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 29 11:31:46 PDT 2019
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: ormris.
Interesting approach!
LGTM modulo my comment.
================
Comment at: llvm/unittests/Support/FileCollectorTest.cpp:212
+ EXPECT_TRUE(Collector->hasSeen(subdir3a.Path));
+ EXPECT_TRUE(Collector->hasSeen(subdir3b.Path));
+}
----------------
Maybe add one more test that ensures we don't record files that don't exist?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65411/new/
https://reviews.llvm.org/D65411
More information about the llvm-commits
mailing list