[PATCH] D65255: [yaml2obj] Move core yaml2obj code into lib and include for use in unittests

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/ObjectYAML/COFFEmitter.cpp:34
 /// See docs/yaml2obj for the yaml scheema.
 struct COFFParser {
   COFFParser(COFFYAML::Object &Obj)
----------------
This struct should be in the anonymous namespace.


================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:58
 };
 } // end anonymous namespace
 
----------------
You're closing the anonymous namespace here, but start one again about 3 lines later. Merge them together.


================
Comment at: llvm/lib/ObjectYAML/WasmEmitter.cpp:25
 /// See docs/yaml2obj for the yaml scheema.
 class WasmWriter {
 public:
----------------
This class should be in the anonymous namespace.


================
Comment at: llvm/test/tools/yaml2obj/invalid-docnum.test:1
+## Test error output when a higher docnum is specified than that are valid
+## yaml inputs in the file.
----------------
This sentence is poor grammar. Probably something like "Test that an error is reported when a docnum is specified, which is greater than the number of YAML inputs in the file."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65255/new/

https://reviews.llvm.org/D65255