[PATCH] D65398: [ARM] Generate MVE VFMAs

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 29 08:03:55 PDT 2019


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Looks good to me, with one minor formatting nit.



================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2582
+  def : Pat<(v8f16 (fadd (v8f16 MQPR:$src1),
+                             (fmul (v8f16 MQPR:$src2),
+                                      (v8f16 MQPR:$src3)))),
----------------
Nit: you line this up a little, based on the brackets. I mean something like:
```
  def : Pat<(v4f32 (fadd (v4f32 MQPR:$src1),
                         (fmul (v4f32 MQPR:$src2),
                               (v4f32 MQPR:$src3)))),
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65398/new/

https://reviews.llvm.org/D65398





More information about the llvm-commits mailing list