[PATCH] D64925: [IR] Add getArg() method to Function class

Mon Jul 29 07:37:31 PDT 2019

tejohnson added a comment.

In D64925#1602949 <https://reviews.llvm.org/D64925#1602949>, @hmwildermuth wrote:

> In D64925#1599789 <https://reviews.llvm.org/D64925#1599789>, @tejohnson wrote:
>
> > Suggest sending this change with patch that uses and tests it.
>
>
> @tejohnson any more recommendations?

It looks fine but is there a plan for a follow on patch that uses this new facility in the code (not just in a unit test)? Wondering since I see that the type of arg_begin() is actually "Argument *" so there is already a fair amount of code that just does something like either arg_begin()[index] or arg_begin()+index. Not opposed to adding a new interface for this, but wondering what the motivating case is.

Also, for future patches - please upload patches with context (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) to make them easier to review.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64925/new/

https://reviews.llvm.org/D64925