[PATCH] D65370: libcxx: Define __STDCPP_THREADS__ to 1, not to __cplusplus.
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 29 07:37:09 PDT 2019
thakis added a comment.
Did most things, except that I kept it in thread for now. PTAL.
================
Comment at: libcxx/include/thread:110
-#define __STDCPP_THREADS__ __cplusplus
+#define __STDCPP_THREADS__ 1
----------------
EricWF wrote:
> This should be defined by the compiler, not the library. So we should only define it if it hasn't already been defined.
Currently it's only defined if thread is included; in __config it'd always be defined. Is the latter what we want? If the compiler doesn't define it, if <thread> is included seems like an ok signal.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65370/new/
https://reviews.llvm.org/D65370
More information about the llvm-commits
mailing list