[PATCH] D64665: [MachinePipeliner] Refactor schedule emission logic

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 29 07:37:08 PDT 2019


jmolloy updated this revision to Diff 212147.
jmolloy added a comment.

Hi Brendon,

Thanks for your great explanation! I've now spent a good 2 weeks refactoring this, and what I have now I'm pretty happy with.

I think it reduces the complexity down quite a lot, it does handle all of the weird cases in the Hexagon test-suite (although I've been focussing so much on Hexagon I still have failures in the PowerPC suite - trivial regclass fix).

I'd appreciate your input on this patchset. I think it needs a bit more cleanup, but I've been cleaning it up for quite some time now so eventually I do have to submit it for review ;)

It'd be great if you could run it through your internal test suite and see if anything strange comes out?

Cheers!

James


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64665/new/

https://reviews.llvm.org/D64665

Files:
  include/llvm/CodeGen/MachinePipeliner.h
  lib/CodeGen/MachineLoopUtils.cpp
  lib/CodeGen/MachineLoopUtils.h
  lib/CodeGen/MachinePipeliner.cpp
  test/CodeGen/Hexagon/swp-epilog-phi11.ll
  test/CodeGen/Hexagon/swp-epilog-phi6.ll
  test/CodeGen/Hexagon/swp-epilog-phi7.ll
  test/CodeGen/Hexagon/swp-matmul-bitext.ll
  test/CodeGen/Hexagon/swp-xxh2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64665.212147.patch
Type: text/x-patch
Size: 45549 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190729/1771b21d/attachment-0001.bin>


More information about the llvm-commits mailing list