[PATCH] D60942: Emit diagnostic if an inline asm constraint requires an immediate

Joerg Sonnenberger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 27 13:13:25 PDT 2019


joerg accepted this revision.
joerg added a comment.
This revision is now accepted and ready to land.

LGTM otherwise.



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:8055
+        OpInfo.CallOperand && !isa<ConstantSDNode>(OpInfo.CallOperand))
+      // We've delayed emitting a diagnostic line the "n" constraint because
+      // inlining could cause an integer showing up.
----------------
Typo still.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60942/new/

https://reviews.llvm.org/D60942





More information about the llvm-commits mailing list