[PATCH] D65346: [llvm-objcopy] Improve --add-section argument string parsing

Sat Jul 27 11:18:52 PDT 2019

abrachet marked an inline comment as done.
abrachet added inline comments.

================
Comment at: llvm/test/tools/llvm-objcopy/ELF/add-section.test:41
+## to be added does not exist.
+# RUN: not llvm-objcopy --add-section=.section.name=%t.missing %t %t.out 2>&1 | FileCheck -DFILE=%t -DFILE1=%t.missing %s --check-prefixes=CHECK-ERR1
+
----------------
sdmitriev wrote:
> grimar wrote:
> > Perhaps `DFILE1` and `DFILE2` would be better when you have 2 files.
> > 
> > I'd also suggest renaming `CHECK-ERR*` -> `ERR*`.
> Done.
Hi @sdmitriev  there is a done check box in the top right of an inline comment that is generally preferred to responding done. That way others can us the 'Hide "done" Inlines" option and it's also less noise. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65346/new/

https://reviews.llvm.org/D65346