[PATCH] D65070: [LLVM-C][OCaml] Add a fast linker binding

[whitequark via Phabricator via llvm-commits]

whitequark requested changes to this revision.
whitequark added inline comments.
This revision now requires changes to proceed.


================
Comment at: bindings/ocaml/linker/linker_ocaml.c:40
+
+static value *internalize_trampoline_callback_value = NULL;
+
----------------
I think the proliferation of non-reentrant/non-threadsafe functions in the API is an issue. (Right now OCaml has a global lock, but a multicore runtime is in works.) The approach in D65138 is better, but still seems error-prone to me; I'll need to take a closer look at the OCaml runtime feature to see if perhaps a better one is possible.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65070/new/

https://reviews.llvm.org/D65070