[PATCH] D65073: [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

Since this patch we get

  ../../clang-tools-extra/clangd/Selection.cpp:80:13: error: unused function 'printNodeToString' [-Werror,-Wunused-function]
  std::string printNodeToString(const DynTypedNode &N, const PrintingPolicy &PP) {
              ^
  ../../clang-tools-extra/clangd/Selection.cpp:351:25: error: private field 'PrintPolicy' is not used [-Werror,-Wunused-private-field]
    const PrintingPolicy &PrintPolicy;
                          ^
  2 errors generated.

When building with -DNDEBUG and -Werror.

I guess we can sprinkle some ifndef NDEBUG in this file, but I'm not sure how these dlog statements normally are handled in clang-tools-extra. Should for example LLVM_ENABLE_DUMP also be used for clang-tools-extra?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65073/new/

https://reviews.llvm.org/D65073