[PATCH] D65213: [ELF] With --vs-diagnostics, print a separate message for each location of a duplicate symbol.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: Common/ErrorHandler.cpp:182
+        R"((\n>>> defined at \S+:\d+\n>>>.*))");
+    std::string msgStr = msg.str();
+    std::smatch match;
----------------
I'd inline `msgStr`.


================
Comment at: Common/ErrorHandler.cpp:186
+      printError(match.str(1) + match.str(2));
+      printError(match.str(1) + match.str(3));
+      return;
----------------
BTW, this might print only the first error if `errorLimit` is reached.
(I am not sure how much it is critical though).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65213/new/

https://reviews.llvm.org/D65213