[llvm] r367159 - Fix remarks unit test on Windows
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 26 15:10:45 PDT 2019
Author: rnk
Date: Fri Jul 26 15:10:44 2019
New Revision: 367159
URL: http://llvm.org/viewvc/llvm-project?rev=367159&view=rev
Log:
Fix remarks unit test on Windows
"no such file or directory" vs "No such file or directory"
Modified:
llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp
Modified: llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp?rev=367159&r1=367158&r2=367159&view=diff
==============================================================================
--- llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp (original)
+++ llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp Fri Jul 26 15:10:44 2019
@@ -63,6 +63,14 @@ bool parseExpectError(const char (&Buf)[
return StringRef(Stream.str()).contains(Error);
}
+static std::string toLower(StringRef S) {
+ std::string R;
+ R.reserve(S.size());
+ for (char C : S)
+ R += std::tolower(C);
+ return R;
+}
+
void parseExpectErrorMeta(StringRef Buf, const char *Error) {
std::string ErrorStr;
raw_string_ostream Stream(ErrorStr);
@@ -71,7 +79,10 @@ void parseExpectErrorMeta(StringRef Buf,
remarks::createRemarkParserFromMeta(remarks::Format::YAML, Buf);
handleAllErrors(MaybeParser.takeError(),
[&](const ErrorInfoBase &EIB) { EIB.log(Stream); });
- EXPECT_EQ(Stream.str(), Error);
+
+ // Use a case insensitive comparision due to case differences in error strings
+ // for different OSs.
+ EXPECT_EQ(toLower(Stream.str()), toLower(Error));
}
TEST(YAMLRemarks, ParsingEmpty) {
More information about the llvm-commits
mailing list