[PATCH] D65310: [JumpThreading] In updatePredecessorProfileMetadata, stop searching predecessor when the current bb is an unreachable single bb loop

[Eli Friedman via llvm-commits]

From: Wei Mi <wmi at google.com>
Sent: Friday, July 26, 2019 11:54 AM
To: reviews+D65310+public+218d41e11489d8c7 at reviews.llvm.org
Cc: David Li <davidxl at google.com>; Eli Friedman <efriedma at quicinc.com>; brzycki at gmail.com; simachijun at gmail.com; hiraditya at msn.com; jfbastien at apple.com; llvm-commits <llvm-commits at lists.llvm.org>; jun.l at samsung.com; florian_hahn at apple.com; czhengsz at cn.ibm.com
Subject: [EXT] Re: [PATCH] D65310: [JumpThreading] In updatePredecessorProfileMetadata, stop searching predecessor when the current bb is an unreachable single bb loop


On Fri, Jul 26, 2019 at 11:34 AM Eli Friedman via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:

Calling getDomTree() here is expensive; it flushes all updates in the DomTreeUpdater.

Or I can detect loop using a set keeping nodes which have been visited. Whenever SinglePredBB is seen in the set, stop searching.

That’s fine.

-Eli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190726/4ff60fac/attachment.html>