[llvm] r367142 - add 'a' to chmod in llvm-lipo executability tests

[Bob Haarman via llvm-commits]

Author: inglorion
Date: Fri Jul 26 11:44:06 2019
New Revision: 367142

URL: http://llvm.org/viewvc/llvm-project?rev=367142&view=rev
Log:
add 'a' to chmod in llvm-lipo executability tests

Summary:
When specifying symbolic permissions with + or -, if none of
a/u/g/o are specified, bits set in the umask are not affected.
This caused the llvm-lipo executability tests to fail on some
systems, e.g. having an umask of 027 would cause chmod -x to not
clear the executable bit for others. This change instead
uses chmod a-x, which clears all the executable bits regardless
of umask.

Reviewers: smeenai, hans, anushabasana

Reviewed By: smeenai

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65342

Modified:
    llvm/trunk/test/tools/llvm-lipo/create-executable.test
    llvm/trunk/test/tools/llvm-lipo/thin-executable-universal-binary.test

Modified: llvm/trunk/test/tools/llvm-lipo/create-executable.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-lipo/create-executable.test?rev=367142&r1=367141&r2=367142&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-lipo/create-executable.test (original)
+++ llvm/trunk/test/tools/llvm-lipo/create-executable.test Fri Jul 26 11:44:06 2019
@@ -3,11 +3,11 @@
 # RUN: yaml2obj %p/Inputs/i386-slice.yaml > %t-i386.o
 # RUN: yaml2obj %p/Inputs/x86_64-slice.yaml > %t-x86_64.o
 
-# RUN: chmod -x %t-i386.o
-# RUN: chmod -x %t-x86_64.o
+# RUN: chmod a-x %t-i386.o
+# RUN: chmod a-x %t-x86_64.o
 # RUN: llvm-lipo %t-i386.o %t-x86_64.o -create -output %t-universal.o
 # RUN: test ! -x %t-universal.o
 
-# RUN: chmod +x %t-i386.o
+# RUN: chmod a+x %t-i386.o
 # RUN: llvm-lipo %t-i386.o %t-x86_64.o -create -output %t-universal.o
 # RUN: test -x %t-universal.o

Modified: llvm/trunk/test/tools/llvm-lipo/thin-executable-universal-binary.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-lipo/thin-executable-universal-binary.test?rev=367142&r1=367141&r2=367142&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-lipo/thin-executable-universal-binary.test (original)
+++ llvm/trunk/test/tools/llvm-lipo/thin-executable-universal-binary.test Fri Jul 26 11:44:06 2019
@@ -2,11 +2,11 @@
 # UNSUPPORTED: system-windows
 # RUN: yaml2obj %s > %t-universal.o
 
-# RUN: chmod -x %t-universal.o
+# RUN: chmod a-x %t-universal.o
 # RUN: llvm-lipo %t-universal.o -thin i386 -output %t32.o
 # RUN: test ! -x %t32.o
 
-# RUN: chmod +x %t-universal.o
+# RUN: chmod a+x %t-universal.o
 # RUN: llvm-lipo %t-universal.o -thin i386 -output %t32-ex.o
 # RUN: test -x %t32-ex.o