[PATCH] D63547: [AIX]Global Address Lowering

[Sean Fertile via Phabricator via llvm-commits]

sfertile accepted this revision.
sfertile added a comment.
This revision is now accepted and ready to land.

A minor comment, but otherwise LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCTOCRegDeps.cpp:115
+        MBB.getParent()->getSubtarget<PPCSubtarget>();
+      const bool is32BitAIX = !Subtarget.isPPC64() && Subtarget.isAIXABI();
+      const unsigned TOCReg = (!is32BitAIX) ? PPC::X2 : PPC::R2;
----------------
minor nit: We only need to check `isPPC64()`, and not `isAIXABI()'.  If you want to document that `isAIXABI()` is true whenever isPPC64() is false then an assert will do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63547/new/

https://reviews.llvm.org/D63547