[PATCH] D65334: [llvm] [FileCheck] Use FILECHECK_DUMP_INPUT_ON_FAILURE only when non-empty

Fri Jul 26 08:53:17 PDT 2019

mgorny added a comment.

In D65334#1602696 <https://reviews.llvm.org/D65334#1602696>, @jdenny wrote:

> In D65334#1602675 <https://reviews.llvm.org/D65334#1602675>, @mgorny wrote:
>
> > We are using it to force verbose output on buildbot ;-).
>
>
> Good to know.  By the way, you'd get roughly the same output with `FILECHECK_OPTS=-dump-input=fail`, which is not deprecated.  Adding `-v` or `-vv` will provide much more info.

Hm, indeed. However, when grepping help I've noticed `FILECHECK_DUMP_INPUT_ON_FAILURE` but not `FILECHECK_OPTS` ;-).

> 
> 
>> But setting to an empty value should be very uncommon.
> 
> Agreed.
> 
>> The uses I've been able to grep in LLVM all set it to `1`.
> 
> You mean the FileCheck test suite?  Or are you grepping some user code?

The former.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65334/new/

https://reviews.llvm.org/D65334