[PATCH] D60942: Emit diagnostic if an inline asm constraint requires an immediate

Joerg Sonnenberger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 26 08:25:08 PDT 2019


joerg added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:439
+                  break;
+                }
             } else if (MI->getOperand(OpNo).isMBB()) {
----------------
This is an unrelated chunk. Can you drop it please? I like the idea, but it would be nicer if it didn't need to create an intermediate label at all.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60942/new/

https://reviews.llvm.org/D60942





More information about the llvm-commits mailing list