[PATCH] D65334: [llvm] [FileCheck] Use FILECHECK_DUMP_INPUT_ON_FAILURE only when non-empty
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 26 08:22:40 PDT 2019
jdenny accepted this revision.
jdenny added a comment.
This revision is now accepted and ready to land.
LGTM as is.
A few notes we should keep in mind anyway: `FILECHECK_DUMP_INPUT_ON_FAILURE` is deprecated, so I agree that this simple change is probably sufficient (we don't need to check for 0, for example). I wonder if anyone still uses it. If so, this patch might break some uses, but I think users could easily adjust. If not, we should consider removing it.
Thanks.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65334/new/
https://reviews.llvm.org/D65334
More information about the llvm-commits
mailing list