[llvm] r367099 - [NFC][ARM][ParallelDSP] Cleanup isNarrowSequence
Sam Parker via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 26 03:57:42 PDT 2019
Author: sam_parker
Date: Fri Jul 26 03:57:42 2019
New Revision: 367099
URL: http://llvm.org/viewvc/llvm-project?rev=367099&view=rev
Log:
[NFC][ARM][ParallelDSP] Cleanup isNarrowSequence
Remove unused logic.
Modified:
llvm/trunk/lib/Target/ARM/ARMParallelDSP.cpp
Modified: llvm/trunk/lib/Target/ARM/ARMParallelDSP.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMParallelDSP.cpp?rev=367099&r1=367098&r2=367099&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMParallelDSP.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMParallelDSP.cpp Fri Jul 26 03:57:42 2019
@@ -335,38 +335,17 @@ bool ARMParallelDSP::AreSequentialLoads(
// why we check that types are equal to MaxBitWidth, and not <= MaxBitWidth.
template<unsigned MaxBitWidth>
bool ARMParallelDSP::IsNarrowSequence(Value *V, ValueList &VL) {
- ConstantInt *CInt;
-
- if (match(V, m_ConstantInt(CInt))) {
- // TODO: if a constant is used, it needs to fit within the bit width.
- return false;
- }
-
- auto *I = dyn_cast<Instruction>(V);
- if (!I)
- return false;
-
- Value *Val, *LHS, *RHS;
- if (match(V, m_Trunc(m_Value(Val)))) {
- if (cast<TruncInst>(I)->getDestTy()->getIntegerBitWidth() == MaxBitWidth)
- return IsNarrowSequence<MaxBitWidth>(Val, VL);
- } else if (match(V, m_Add(m_Value(LHS), m_Value(RHS)))) {
- // TODO: we need to implement sadd16/sadd8 for this, which enables to
- // also do the rewrite for smlad8.ll, but it is unsupported for now.
- return false;
- } else if (match(V, m_ZExtOrSExt(m_Value(Val)))) {
- if (cast<CastInst>(I)->getSrcTy()->getIntegerBitWidth() != MaxBitWidth)
+ if (auto *SExt = dyn_cast<SExtInst>(V)) {
+ if (SExt->getSrcTy()->getIntegerBitWidth() != MaxBitWidth)
return false;
- if (match(Val, m_Load(m_Value()))) {
- auto *Ld = cast<LoadInst>(Val);
-
+ if (auto *Ld = dyn_cast<LoadInst>(SExt->getOperand(0))) {
// Check that these load could be paired.
if (!LoadPairs.count(Ld) && !OffsetLoads.count(Ld))
return false;
- VL.push_back(Val);
- VL.push_back(I);
+ VL.push_back(Ld);
+ VL.push_back(SExt);
return true;
}
}
More information about the llvm-commits
mailing list