[PATCH] D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1]
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 26 01:55:53 PDT 2019
grimar added inline comments.
================
Comment at: llvm/include/llvm/Object/MutableELFObject.h:27
+
+template <typename ELFT> class MutableELFSection {
+public:
----------------
Since all members are `public`, should this be a `struct`?
================
Comment at: llvm/unittests/Object/MutableELFObjectTest.cpp:21
+
+TEST(MutableELFObject, ChangeSectionName) {
+ SmallString<0> Storage;
----------------
I'd suggest adding a short description comment before each unit test
(about what this test intended to do) just like we often do in a regular test files.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64281/new/
https://reviews.llvm.org/D64281
More information about the llvm-commits
mailing list