[PATCH] D58702: Enabled Backtraces with just ENABLE_BACKTRACES

[yifeihe via Phabricator via llvm-commits]

yifeihe added a comment.

Hi！
This move will call AddSignalHandler and enable SetUnhandledExceptionFilter in llvm\lib\Support\Windows\signals.inc. In our application, llvm's component is called as a library , and the Unhandled Exception handler set in our application is over written by the llvm.
I think the application, not one of its components, should be responsible for application-wide error handling and reporting policy. Any libraries called from application should not permanently change global exception handler. This is reserved for application code (not the library code).
The llvm called as a library may change the exception handler temporarily, but must restore the handler before call finishes.
To sum up my point of view, permanently changing UnhandledExceptionFilter in library code is a bug that should be fixed


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58702/new/

https://reviews.llvm.org/D58702