[PATCH] D65278: [llvm-objcopy] - Stop using Inputs/alloc-symtab.o.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 19:59:50 PDT 2019


MaskRay added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/binary-out-error.test:2
+# RUN: yaml2obj %s -o %t
+# RUN: not llvm-objcopy -O binary %t %t2 2>&1 >/dev/null | FileCheck %s --check-prefix=SYMTAB
 # SYMTAB: cannot write symbol table '.symtab' out to binary
----------------
`not llvm-objcopy -O binary %t - 2>&1 | FileCheck %s --check-prefix=SYMTAB`



================
Comment at: test/tools/llvm-objcopy/ELF/invalid-preserve-dates.test:18
 
 ## Testing N args.
+# RUN: not llvm-strip --preserve-dates - < %t.foo 2>&1 | FileCheck %s
----------------
> Testing N args.

Can you improve the comment?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65278/new/

https://reviews.llvm.org/D65278





More information about the llvm-commits mailing list