[PATCH] D65310: [JumpThreading] In updatePredecessorProfileMetadata, stop searching predecessor when the current bb is an unreachable single bb loop

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 19:18:15 PDT 2019


wmi added a comment.

In D65310#1601929 <https://reviews.llvm.org/D65310#1601929>, @efriedma wrote:

> Is there any reason to expect that unreachable loops have exactly one block?


I was wrong. I thought getSinglePredecessor already handle the case but I didn't think it carefully enough. Thanks for catching it.

I update the patch to stop searching whenever unreachable code is seen, and update the test with unreachable multi-bbs loop case.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65310/new/

https://reviews.llvm.org/D65310





More information about the llvm-commits mailing list