[PATCH] D65307: Appending COMPILER_RT_LIBCXX_PATH include path to -isystem for compiler-rt xray

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: lib/xray/CMakeLists.txt:122
+if(COMPILER_RT_USE_LIBCXX)
+  if (SANITIZER_CXX_ABI_LIBNAME STREQUAL "libc++")
+    set(SANITIZER_COMMON_CFLAGS "${SANITIZER_COMMON_CFLAGS} -isystem ${COMPILER_RT_LIBCXX_PATH}/include")
----------------
I think that the ABI is unused here since we are not using the libc++abi headers here.  Lets just simplify this to just be conditional on `COMPILER_RT_USE_LIBCXX`.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65307/new/

https://reviews.llvm.org/D65307