[PATCH] D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX

Pirama Arumuga Nainar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 14:29:58 PDT 2019


pirama marked an inline comment as done.
pirama added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingUtil.c:52
+  const char *gcov_prefix = getenv("GCOV_PREFIX");
+  const int gcov_prefix_len = strlen(gcov_prefix);
+  if (gcov_prefix != NULL && strncmp(path, gcov_prefix, gcov_prefix_len) == 0)
----------------
davidxl wrote:
> needs null check of gcov_prefix.
Aah, good catch.  Sorry I missed this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65245/new/

https://reviews.llvm.org/D65245





More information about the llvm-commits mailing list