[PATCH] D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX

[Pirama Arumuga Nainar via Phabricator via llvm-commits]

pirama updated this revision to Diff 211818.
pirama added a comment.

Refactored the loop to call getenv just once.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65245/new/

https://reviews.llvm.org/D65245

Files:
  compiler-rt/lib/profile/InstrProfilingUtil.c


Index: compiler-rt/lib/profile/InstrProfilingUtil.c
===================================================================
--- compiler-rt/lib/profile/InstrProfilingUtil.c
+++ compiler-rt/lib/profile/InstrProfilingUtil.c
@@ -39,11 +39,26 @@
 COMPILER_RT_VISIBILITY
 void __llvm_profile_recursive_mkdir(char *path) {
   int i;
+  int start = 1;
+
+#if defined(__ANDROID__) && defined(__ANDROID_API__) && \
+    defined(__ANDROID_API_FUTURE__) && __ANDROID_API__==__ANDROID_API_FUTURE__
+  // Avoid spammy selinux denial messages in Android by not attempting to
+  // create directories in GCOV_PREFIX.  These denials occur when creating (or
+  // even attempting to stat()) top-level directories like "/data".
+  //
+  // Do so by ignoring ${GCOV_PREFIX} when invoking mkdir().
+  const char *gcov_prefix = getenv("GCOV_PREFIX");
+  const int gcov_prefix_len = strlen(gcov_prefix);
+  if (gcov_prefix != NULL && strncmp(path, gcov_prefix, gcov_prefix_len) == 0)
+    start = gcov_prefix_len;
+#endif
 
-  for (i = 1; path[i] != '\0'; ++i) {
+  for (i = start; path[i] != '\0'; ++i) {
     char save = path[i];
     if (!IS_DIR_SEPARATOR(path[i]))
       continue;
+
     path[i] = '\0';
 #ifdef _WIN32
     _mkdir(path);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65245.211818.patch
Type: text/x-patch
Size: 1217 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190725/38b0e54d/attachment.bin>