[PATCH] D65292: [Loop Peeling] Fix idom detection algorithm

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 25 11:01:21 PDT 2019


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopUnroll/peel-loop-pgo-deopt-idom-2.ll:2
+; REQUIRES: asserts
+; RUN: opt < %s -S -debug-only=loop-unroll -loop-unroll -unroll-runtime -unroll-peel-multi-deopt-exit 2>&1 | FileCheck %s
+; RUN: opt < %s -S -debug-only=loop-unroll -unroll-peel-multi-deopt-exit -passes='require<profile-summary>,function(require<opt-remark-emit>,unroll)' 2>&1 | FileCheck %s
----------------
fhahn wrote:
> I *think* if you pass `-verify-dom-info`, you do not require asserts for the assertion in LoopUnrollPeel.cpp:735. It will verify the DT after unrolling/peeling, which should be sufficient.
ah you check the debug output, never mind.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65292/new/

https://reviews.llvm.org/D65292





More information about the llvm-commits mailing list