[PATCH] D64759: [CodeGen] Don't resolve the stack protector frame accesses until PEI
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 25 04:58:05 PDT 2019
sdesmalen added a comment.
In D64759#1599989 <https://reviews.llvm.org/D64759#1599989>, @thegameg wrote:
> In D64759#1599892 <https://reviews.llvm.org/D64759#1599892>, @efriedma wrote:
>
> > If there isn't any free register, the scavenger will spill a register to the emergency spill slot. That doesn't have to be any particular register; it can be basically any allocatable register. So if one or two registers are particularly sensitive, we could specifically forbid the scavenger from spilling them.
>
>
> I agree, we could do that. It would require parts of the code to keep track of the register used for the guard and avoid it at all cost. Do you think this is blocking for this fix to get in?
Is it worth, as a first step, to always enable the FP when using stack guards?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64759/new/
https://reviews.llvm.org/D64759
More information about the llvm-commits
mailing list