[PATCH] D64327: [ELF] Loose condition for relocation with a symbol

Thu Jul 25 04:18:45 PDT 2019

MaskRay added a comment.

In D64327#1600769 <https://reviews.llvm.org/D64327#1600769>, @NikolaPrica wrote:

> This patch is reverted. Bug in gold compiler is not solved after all. We tested this functionality without optimizations enabled. With the "-O2" flag bug is still present.

@NikolaPrica Do you mean with the linker option `-O2`, i.e. the compiler driver option `-Wl,-O2`, gold can produce incorrect result? If that is the case, I don't think we should revert the patch. ld.bfd and gold default to `-O0` (lld defaults to `-O1`), it is extremely rare for a project to specify `-Wl,-O2`.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64327/new/

https://reviews.llvm.org/D64327