[PATCH] D64066: Add geomean column earlier to dataout as Series in compare.py.

[Florian Hahn via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL367002: Add geomean column earlier to dataout as Series in compare.py. (authored by fhahn, committed by ).

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64066/new/

https://reviews.llvm.org/D64066

Files:
  test-suite/trunk/utils/compare.py


Index: test-suite/trunk/utils/compare.py
===================================================================
--- test-suite/trunk/utils/compare.py
+++ test-suite/trunk/utils/compare.py
@@ -141,8 +141,8 @@
 
     gm_row = {c: '' for c in dataout.columns}
     gm_row['diff'] = gm_diff
-    gm_row['Program'] = 'Geomean difference'
-    return dataout.append(gm_row, ignore_index=True)
+    series = pd.Series(gm_row, name='Geomean difference')
+    return dataout.append(series)
 
 def filter_failed(data, key='Exec'):
     return data.loc[data[key] == "pass"]
@@ -220,12 +220,12 @@
         # Take 15 topmost elements
         dataout = dataout.head(15)
 
+    if show_diff_column:
+      dataout = add_geomean_row(d, dataout)
+
     # Turn index into a column so we can format it...
     dataout.insert(0, 'Program', dataout.index)
 
-    if show_diff_column:
-        dataout = add_geomean_row(d, dataout)
-
     formatters = dict()
     formatters['diff'] = format_diff
     if shorten_names:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64066.211704.patch
Type: text/x-patch
Size: 996 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190725/ef08b1f0/attachment.bin>