[PATCH] D65040: [llvm-objcopy] Add support for --add-section for COFF

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/add-section.test:20
+
+## Test that llvm-objcopy can add a section with empty name.
+# RUN: llvm-objcopy --add-section==%t.sec %t %t1.empty.name
----------------
Nit: "with an empty name"


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/add-section.test:44
+
+# CHECK-ERR2: llvm-objcopy{{(.exe)?}}: error:{{.+}}[[FILE]]{{.+}} bad format for --add-section
+
----------------
What does the "{{.+}}" here (and in the case above) capture? I'm not sure they're useful?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65040/new/

https://reviews.llvm.org/D65040