[PATCH] D63972: [PowerPC] Do the Early Return for the li and unconditional branch

Zhang Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 24 18:57:15 PDT 2019


ZhangKang added a comment.

Have updated the patch.



================
Comment at: llvm/lib/CodeGen/MachineBlockPlacement.cpp:2738
+        // ChainBB and TBB. This is legal under the one of following conditions:
+        // 1. ChainBB has only one unconditional branch.
+        // 2. TBB has only one predecessor.
----------------
efriedma wrote:
> Maybe instead of "has only one unconditional branch", say "is empty except for an unconditional branch"
I will do it.


================
Comment at: llvm/test/CodeGen/PowerPC/block-placement-1.mir:302
   ; CHECK:      bb.1.for.body:
-  ; CHECK:        successors: %bb.2(0x7ffff800), %bb.3(0x00000800)
-  ; CHECK:        B %bb.2
+  ; CHECK-NET:    successors: %bb.3(0x00000800)
 
----------------
efriedma wrote:
> "CHECK-NET"?
`CHECK-NEXT`, I will fix it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63972/new/

https://reviews.llvm.org/D63972





More information about the llvm-commits mailing list