[PATCH] D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:6841-6842
 
   case Intrinsic::amdgcn_raw_buffer_store:
   case Intrinsic::amdgcn_raw_buffer_store_format: {
     SDValue VData = Op.getOperand(2);
----------------
tstellar wrote:
> arsenm wrote:
> > Why aren't these handled?
> I didn't handle the raw or struct intrinsics, because I wasn't sure if the swizzling or something else from the resource descriptor affected the offset value.  
I think the point of splitBufferOffsets is to abstract this, so it should be the same. I think the non struct/raw versions are deprecated 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65097/new/

https://reviews.llvm.org/D65097