[PATCH] D65204: [GVN] Also invalidate users of instructions replaced due to conditionals.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Oh, okay, that makes more sense.

> cache them using the translated pointer (%_tmp47)

Does it really make sense to cache the load %_tmp58 using the pointer %_tmp47, as opposed to the pointer %_tmp57?  There isn't any dominance relationship between %_tmp47 and %_tmp58.

> Now there is still a potential problem as we just invalidate values 2 levels deep

This seems concerning, yes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65204/new/

https://reviews.llvm.org/D65204