[PATCH] D60389: FileCheck [9/12]: Add support for matching formats

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:35
+  if (!Hex)
+    return StringRef("[[:digit:]]+");
+  if (Cap)
----------------
Maybe `[0-9]+` instead of `"[[:digit:]]+"`?


================
Comment at: llvm/lib/Support/FileCheck.cpp:92
     return true;
-  if (ExpressionAST != nullptr) {
-    Expected<uint64_t> EvaluatedValue = ExpressionAST->eval();
+  if (Expression != nullptr && Expression->getAST() != nullptr) {
+    Expected<uint64_t> EvaluatedValue = Expression->getAST()->eval();
----------------
`if (Expression && Expression->getAST())` is a bit shorter and just as readable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60389/new/

https://reviews.llvm.org/D60389