[PATCH] D62434: [lld-link] diagnose undefined symbols before LTO when possible
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 24 12:12:08 PDT 2019
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/COFF/SymbolTable.cpp:143
+ llvm_unreachable("unsupported file type passed to getSymbolLocations");
+ return {};
+}
----------------
I don't think you need this `return` after an unreachable statement. I believe all C++ compilers that are smart enough to recognize that this function always return a value or abort. (If it would fail on a buildbot, we can add this line later.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62434/new/
https://reviews.llvm.org/D62434
More information about the llvm-commits
mailing list