[PATCH] D65162: [llvm-profdata] Profile dump for compact binary format

[Wenlei He via Phabricator via llvm-commits]

wenlei marked an inline comment as done.
wenlei added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProfReader.h:284
 
+  virtual void markAllFuncToUse() {}
+
----------------
wmi wrote:
> We may not need markAllFuncToUse. We can just set UseAllFuncs to False inside of collectFuncsToUse. 
> 
> A related thing is that is it better to set UseAllFuncs to True by default and only set UseAllFuncs to False in collectFuncsToUse? The reason is we have some out-of-tree tools which needs to read profiles of all functions, so it will be easier for them by setting UseAllFuncs to True by default. 
Thanks for the suggestion, Wei. Agreed it's better to have the flag default to true. Updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65162/new/

https://reviews.llvm.org/D65162