[PATCH] D65140: [yaml2obj] - Allow custom fields for the SHT_UNDEF sections.

Wed Jul 24 10:14:52 PDT 2019

phosek added a comment.

The `elf-custom-null-section.yaml` test is failing on macOS with the following error:

  FAIL: LLVM :: tools/yaml2obj/elf-custom-null-section.yaml (32620 of 32657)
  ******************** TEST 'LLVM :: tools/yaml2obj/elf-custom-null-section.yaml' FAILED ********************
  Script:
  --
  : 'RUN: at line 5';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=1 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp1
  : 'RUN: at line 6';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp1 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=DEFAULT
  : 'RUN: at line 25';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=2 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp2
  : 'RUN: at line 26';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp2 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=DEFAULT
  : 'RUN: at line 47';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=3 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp3
  : 'RUN: at line 48';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp3 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=REDEFINE
  : 'RUN: at line 74';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=4 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp4
  : 'RUN: at line 75';   stat /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp3 > /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp.txt
  : 'RUN: at line 76';   stat /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp4 >> /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp.txt
  : 'RUN: at line 77';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --input-file=/b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp.txt --check-prefix=SIZE
  : 'RUN: at line 101';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=5 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp5
  : 'RUN: at line 102';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp5 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=OTHER-SECTION
  : 'RUN: at line 131';   not /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=6 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp6 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=CASE4
  : 'RUN: at line 147';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=7 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp7
  : 'RUN: at line 148';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp7 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=DEFAULT
  : 'RUN: at line 161';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=8 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp8
  : 'RUN: at line 162';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp8 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=MULTIPLE
  : 'RUN: at line 188';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/yaml2obj --docnum=9 /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml -o /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp9
  : 'RUN: at line 189';   /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/llvm-readelf --sections /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp9 | /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml --check-prefix=OVERRIDE
  --
  Exit Code: 1

  Command Output (stderr):
  --
  /b/s/w/ir/k/llvm-project/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml:79:9: error: SIZE: expected string not found in input
  # SIZE: Size: [[FILESIZE:.*]]
          ^
  /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp.txt:1:1: note: scanning from here
  16777218 988254754 -rw-r--r-- 1 chrome-bot staff 0 377 "Jul 24 06:00:40 2019" "Jul 24 06:00:39 2019" "Jul 24 06:00:39 2019" "Jul 24 06:00:39 2019" 4096 8 0 /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp3
  ^
  /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp.txt:1:171: note: possible intended match here
  16777218 988254754 -rw-r--r-- 1 chrome-bot staff 0 377 "Jul 24 06:00:40 2019" "Jul 24 06:00:39 2019" "Jul 24 06:00:39 2019" "Jul 24 06:00:39 2019" 4096 8 0 /b/s/w/ir/k/recipe_cleanup/clangKW_Ksk/llvm_build_dir/test/tools/yaml2obj/Output/elf-custom-null-section.yaml.tmp3
                                                                                                                                                                            ^

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65140/new/

https://reviews.llvm.org/D65140