[PATCH] D64984: [Verifier] Verify all blockaddress constants left over have at least one user.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 24 08:09:20 PDT 2019
fhahn added a comment.
In D64984#1598258 <https://reviews.llvm.org/D64984#1598258>, @efriedma wrote:
> I'm not sure this is something we can reasonably enforce without making big changes in other areas of the compiler. For example, we call eraseFromParent() all over the place, and some large fraction of those calls could eliminate the last use of a blockaddress.
>
> Places that need this soft of cleanup for global variables usually call Constant::removeDeadConstantUsers(). Not sure if we try to do anything like that for blockaddress constants.
Yep it is probably not realistic to get everything clean soon given that it also isn't a huge issue. This might surface some obvious cases/places to clean up though :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64984/new/
https://reviews.llvm.org/D64984
More information about the llvm-commits
mailing list