[PATCH] D65198: [LLD] Do not print additional newlines after reaching error limit

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/Common/ErrorHandler.cpp:166
   } else if (errorCount == errorLimit) {
+    // Note: even though we call newline() in both branches, we can't place it
+    // before the conditions. If we did that, we might emit a newlines (without
----------------
The comment may be too verbose... It should be obvious from the

if .. else if ...

pattern (there is no else branch).

The test may look like:

`env LLD_IN_TEST=0 ld.lld --error-limit=1 %t.o -o /dev/null 2>&1 | FileCheck %s`

(You need to find a multi-line error that can be easily replicated.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65198/new/

https://reviews.llvm.org/D65198